HATEHATEHATE

Mixing multi languages in Namings of classes, Methods and Variables.

HATEHATEHATE

$meinPortal->addUser($aUsers);

where $aUsers is
['benutzername']
['passwort']

Name Database tables and cols even in english, so that fetch() and alike give you $myEnglishvarname['mykey']

A very bad thing is using array key that consist not only of one key case. Example:

$array['myKey']. This is prone to be a source of errors

It can get worse.

1. A DB Table contains a serialized PHP array in $array['myserializeddata'] and is deserialized to

$array['MYSERIALZEDDATA'] = unserialize($array['myserializeddata']);

Interfaces I can see being adjectives.

Class Foo Implements Boxy {}

However, not so much on the class side.

class SealsAndCrofts

class PabloCruz

class LogginsAndOates extends WussRock

Yeah, I just saw “viva ned flanders” this weekend.

My other pet peeve is guys who use one-letter class or variable names. At the same aforementioned company, we had a class called “G” that did all kinds of important and mysterious stuff. The author of that one was an Orthodox Jew and former Adobe employee, so maybe that all fits somehow.

HATEHATEHATE

$meinPortal->addUser($aUsers);

/*
where $aUsers is

There was decently named variable that had over timed turned evil. The name of the variable was something like ‘accountid’. At some point another variable ‘acountid’ came into existence. The variables had the value and the code base was about evenly split in usage. The sad thing was that misspelled variable was not the stupidest thing I saw.